crd-ref-docs icon indicating copy to clipboard operation
crd-ref-docs copied to clipboard
verified publisher icon elastic

Support multi arch release

Open airycanon opened this issue 1 year ago • 3 comments

fix #71, tested with https://github.com/airycanon/crd-ref-docs/releases/tag/v0.0.1

airycanon avatar Apr 10 '24 10:04 airycanon

@thbkrkr @tenstad PTAL

airycanon avatar Apr 22 '24 03:04 airycanon

Thanks for taking care of this. I would prefer that we rely on goreleaser/goreleaser-action and also include the version in the binary like here: https://github.com/elastic/eck-diagnostics/blob/main/.github/workflows/release.yml. Could you follow the same approach?

thbkrkr avatar May 14 '24 11:05 thbkrkr

Thanks for taking care of this. I would prefer that we rely on goreleaser/goreleaser-action and also include the version in the binary like here: https://github.com/elastic/eck-diagnostics/blob/main/.github/workflows/release.yml. Could you follow the same approach?

Thanks for the suggestion. I have already implemented it accordingly, here is a release sample: https://github.com/airycanon/crd-ref-docs/releases/tag/v0.0.1

the version output:

$ ./crd-ref-docs --version
Version: v0.0.1, Commit: aabf3eb, BuildDate: 2024-05-16T03:28:28Z

airycanon avatar May 16 '24 03:05 airycanon

Thank you very much for this contribution.

thbkrkr avatar Jul 25 '24 09:07 thbkrkr