apm icon indicating copy to clipboard operation
apm copied to clipboard

Add elasticsearch_capture_body_urls option

Open felixbarny opened this issue 3 years ago • 2 comments

Refs: https://github.com/elastic/apm-agent-nodejs/issues/2019 Closes: #665

We're only expecting to implement this in the Node.js agent in the near future. Other agents may add this to their roadmap as they see fit but we won't create a cross-agent tracking issue.

  • [x] Create PR as draft
  • [x] Approval by at least one other agent
  • [x] Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • [ ] Merge after 2 business days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.

felixbarny avatar Aug 10 '22 06:08 felixbarny

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-16T11:14:28.625+0000

  • Duration: 3 min 55 sec

apmmachine avatar Aug 10 '22 06:08 apmmachine

Closes elastic/apm-agent-nodejs#2019 and #665

@felixbarny Are you okay with me changing that "Closes" to "Refs", so that the former issue isn't actually closed when this spec goes in? The issue should be closed when we implement the spec.

Update:

Oh, actually, I think what's wanted is:

Refs: https://github.com/elastic/apm-agent-nodejs/issues/2019
Closes: #665

trentm avatar Aug 12 '22 20:08 trentm

As this affects all agents at least in the way the default behaves, I have created implementation issues for all agents and I'm waiting two more days for objections.

felixbarny avatar Aug 16 '22 11:08 felixbarny