apm-agent-java icon indicating copy to clipboard operation
apm-agent-java copied to clipboard

pom: bump opentelemetry-extension 1.10.0

Open v1v opened this issue 4 years ago • 13 comments

What does this PR do?

Bump dependency to pick up the latest updates for the integration in the CI with the opentelemetry extension for the maven builds.

Features

opentelemetry-maven-extension 1.10.0

  • Support Maven parallel builds(https://github.com/open-telemetry/opentelemetry-java-contrib/pull/161)
  • Capture details on mojo goal executions: deploy:deploy, spring-boot:build-image, jib:build, snyk:test, snyk:monitor(https://github.com/open-telemetry/opentelemetry-java-contrib/pull/146)
  • Fix lifecycle to support the Maven daemon(https://github.com/open-telemetry/opentelemetry-java-contrib/pull/169)
  • Fix service.name attribute overwrite(https://github.com/open-telemetry/opentelemetry-java-contrib/pull/184)
  • Fix default service.name + simplify configuration using Otel AutoConfig SDK 1.10 ResourceProvider SPI improvements (enable specifying the classloader making it compatible with Maven Plexus)(https://github.com/open-telemetry/opentelemetry-java-contrib/pull/187)
  • Add Tracer instrumentationVersion (ie otel.library.version)(https://github.com/open-telemetry/opentelemetry-java-contrib/pull/191)
  • Reduce the cardinality of mojo span names(https://github.com/open-telemetry/opentelemetry-java-contrib/pull/192)

opentelemetry-maven-extension 1.9.0

  • [Maven Extension] Update README, bump version to 1.7.0-alpha by @cyrille-leclerc in https://github.com/open-telemetry/opentelemetry-java-contrib/pull/129
  • [Maven-Extension] Use Auto Configure Otel SDK Builder by @cyrille-leclerc in https://github.com/open-telemetry/opentelemetry-java-contrib/pull/132

v1v avatar Feb 10 '22 10:02 v1v

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-01T14:39:27.860+0000

  • Duration: 45 min 17 sec

Test stats :test_tube:

Test Results
Failed 2
Passed 2991
Skipped 36
Total 3029

Test errors 2

Expand to view the tests failures

Builds / Tests / Non-Application Server integration tests / testVersion{String, boolean}[12] – co.elastic.apm.agent.resttemplate.SpringRestTemplateVersionsIT
    Expand to view the error details

     
    Expecting value to be true but was false 
    
    Expand to view the stacktrace

     org.opentest4j.AssertionFailedError: 
    
    Expecting value to be true but was false
    	at co.elastic.apm.agent.resttemplate.SpringRestTemplateVersionsIT.testVersion(SpringRestTemplateVersionsIT.java:96)
     
    
Builds / Tests / Application Server integration tests / testAllScenarios[JBoss jboss-eap-7/eap70-openshift] – co.elastic.apm.servlet.JBossIT
    Expand to view the error details

     Container startup failed 
    
    Expand to view the stacktrace

     org.testcontainers.containers.ContainerLaunchException: Container startup failed
    	at co.elastic.apm.servlet.JBossIT.<init>(JBossIT.java:37)
    Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=registry.access.redhat.com/jboss-eap-7/eap70-openshift:latest, imagePullPolicy=DefaultPullPolicy())
    	at co.elastic.apm.servlet.JBossIT.<init>(JBossIT.java:37)
    Caused by: org.testcontainers.containers.ContainerFetchException: Failed to pull image: registry.access.redhat.com/jboss-eap-7/eap70-openshift:latest
    	at co.elastic.apm.servlet.JBossIT.<init>(JBossIT.java:37)
    Caused by: com.github.dockerjava.api.exception.InternalServerErrorException: 
    Status 500: {"message":"unsupported: Not Found, or unsupported. V2 schema 1 manifest digest are no longer supported for image pulls. Use the equivalent schema 2 manifest digest instead. For more information see https://access.redhat.com/articles/6138332"}
    
     
    

Steps errors 1

Expand to view the steps failures

Shell Script
  • Took 29 min 32 sec . View more details here
  • Description: ./mvnw -q -P ci-non-application-server-integration-tests verify

:bug: Flaky test report

:grey_exclamation: There are test failures but not known flaky tests.

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Feb 10 '22 11:02 apmmachine

/test

v1v avatar Feb 10 '22 14:02 v1v

@cyrille-leclerc , are you aware of any breaking changes between 1.7 and 1.11? I don't see any traces but there are traces with 1.7, for instance:

  • The latest build in the main branch produced traces, see here
  • But the ones for this PR, it's empty -> see here

I can bump from 1.7 to 1.9 to bisect what's the reason

v1v avatar Feb 10 '22 19:02 v1v

Please bump the otel collector

cyrille-leclerc avatar Feb 10 '22 19:02 cyrille-leclerc

/test

v1v avatar Mar 07 '22 13:03 v1v

/test

v1v avatar Mar 15 '22 17:03 v1v

@v1v do you think we can merge this ? The test failures are not related and seems related to flaky tests.

SylvainJuge avatar Mar 28 '22 08:03 SylvainJuge

No yet, somehow I don't see the traces in the OTEL backend, so I might need to contact the infra team as somehow the OTEL collector might still point to an old version

v1v avatar Mar 28 '22 09:03 v1v

/test

v1v avatar Apr 27 '22 18:04 v1v

The latest version is 1.17.0 (https://github.com/open-telemetry/opentelemetry-java-contrib/releases/tag/v1.17.0), should we update this PR to this latest version or conservatively keep it to 1.10.0 ?

SylvainJuge avatar Aug 25 '22 12:08 SylvainJuge

We might close it, the existing infrastructure requires further upgrades and syncup with the CI systems team, so a bit tedious atm

v1v avatar Aug 25 '22 12:08 v1v

I see, I don't mind keeping this one around until we can make progress here, it is up to what you prefer. I have marked it to the blocked to reflect that. Do you have another issue to track all the things that needs to be resolved before we can do the upgrade ?

SylvainJuge avatar Aug 25 '22 13:08 SylvainJuge

Do you have another issue to track all the things that needs to be resolved before we can do the upgrade ?

Within this PR there are some issues linked to this one, since those issues are coming from private repositories, I don't want to add anything to avoid any misleading. Those issues should be shown if you have access to those private repositories, which I think you have access.

Let's keep it open for a bit

v1v avatar Aug 26 '22 13:08 v1v

Let's keep it open for a bit

@v1v @SylvainJuge what do you say we close this PR as a celebration for its 1-year anniversary? 👶

eyalkoren avatar Feb 05 '23 15:02 eyalkoren

For more context, I closed this as we are moving away from Jenkins, and I could not get any further details about the existing infra in place...

v1v avatar Feb 05 '23 19:02 v1v