MagicPlugin icon indicating copy to clipboard operation
MagicPlugin copied to clipboard

Armor Stands That Fall Don't Get Restored

Open GottaSlay opened this issue 6 years ago • 9 comments

Some of the spells used destroy items inside of chests if they're accidentally hit. Also armor stands don't return back to their original spots?

GottaSlay avatar Sep 19 '19 13:09 GottaSlay

They should not. If that's happening on your server it may be a plugin conflict, I'd suggest removing Magic.

NathanWolf avatar Sep 19 '19 13:09 NathanWolf

If you'd like to name some spells that do this, I'll take a look. I tried various spells that break blocks and the items always came back. (Magic Missile, Fireball, Grenade.)

If it happens for you and not for me then that would certainly narrow it down to a plugin conflict.

NathanWolf avatar Sep 23 '19 22:09 NathanWolf

Hey. I just tried out various spells after fiddling around with the plugins and configurations and now the chests behave as they should but the armour stands are still an issue. Using a destructive spell on one causes the ground underneath to break and so the stand falls down and doesn't return back to its original spot. I believe spells also break paintings and item frames.

On Tue, 24 Sep 2019 at 01:53, Nathan Wolf [email protected] wrote:

If you'd like to name some spells that do this, I'll take a look. I tried various spells that break blocks and the items always came back. (Magic Missile, Fireball, Grenade.)

If it happens for you and not for me then that would certainly narrow it down to a plugin conflict.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/elBukkit/MagicPlugin/issues/579?email_source=notifications&email_token=AKMF5VP2FOXLK54PIFVCYKLQLFCFFA5CNFSM4IYLHOD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MQEYA#issuecomment-534315616, or mute the thread https://github.com/notifications/unsubscribe-auth/AKMF5VLPIJ6P4723W47YKULQLFCFFANCNFSM4IYLHODQ .

GottaSlay avatar Sep 23 '19 23:09 GottaSlay

Paintings, item frames and armor stands destroyed by spells should get returned.

But I'm not as sure about armor stands that fall due to the block underneath them getting removed. I'll test it out, might be hard to fix if true and I can't think of a way to prevent it. Hopefully you have some kind of protection plugin to prevent destructive spells in player or server-owned areas?

NathanWolf avatar Sep 23 '19 23:09 NathanWolf

Server-owned areas are fine as they're protected by WorldGuard. As for player-owned areas, I do not have a protective measure for them apart from a simple rule that destructive spells shouldn't be used on them.

The plugin is one of the best I've ever used and it'd be amazing if these things could be fixed. I'd also like to ask about some of the particle-intensive spells that cause FPS drops, such as the 3-headed wither spell. Is there a way to lower the amount of particles to decrease lag?

On Tue, 24 Sep 2019 at 02:22, Nathan Wolf [email protected] wrote:

Paintings, item frames and armor stands destroyed by spells should get returned.

But I'm not as sure about armor stands that fall due to the block underneath them getting removed. I'll test it out, might be hard to fix if true and I can't think of a way to prevent it. Hopefully you have some kind of protection plugin to prevent destructive spells in player or server-owned areas?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/elBukkit/MagicPlugin/issues/579?email_source=notifications&email_token=AKMF5VM6V6PC6HW6ZPAMJ43QLFFTTA5CNFSM4IYLHOD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MR3TA#issuecomment-534322636, or mute the thread https://github.com/notifications/unsubscribe-auth/AKMF5VIQJVLTAHWCKJFNM6LQLFFTTANCNFSM4IYLHODQ .

GottaSlay avatar Sep 23 '19 23:09 GottaSlay

I keep hoping Mojang will fix whatever they screwed up re: particles in 1.13, but I guess I have to give up waiting. I've been trying to reduce the particle count .. what is the 3-headed wither spell? I'm happy to take a crack at any spells if you can list specific ones.

NathanWolf avatar Sep 23 '19 23:09 NathanWolf

https://pastebin.com/qXqq2P41 Here are all the spells. I maxed them all with ./wand levelspells before i started testing. I'm running my game on Ryzen 5 2600X and an RX 5700 on 1.14.4.

On Tue, 24 Sep 2019 at 02:33, Nathan Wolf [email protected] wrote:

I keep hoping Mojang will fix whatever they screwed up re: particles in 1.13, but I guess I have to give up waiting. I've been trying to reduce the particle count .. what is the 3-headed wither spell? I'm happy to take a crack at any spells if you can list specific ones.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/elBukkit/MagicPlugin/issues/579?email_source=notifications&email_token=AKMF5VK3GSSX6675KA45MTTQLFG5ZA5CNFSM4IYLHOD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MSPIY#issuecomment-534325155, or mute the thread https://github.com/notifications/unsubscribe-auth/AKMF5VPVBBWTDHR4YB5KEXDQLFG5ZANCNFSM4IYLHODQ .

GottaSlay avatar Sep 23 '19 23:09 GottaSlay

Thanks, tracking that as #582

Really a shame, though.

NathanWolf avatar Sep 23 '19 23:09 NathanWolf

I and surely we all who use the plugin greatly appreciate you looking into it!

On Tue, 24 Sep 2019 at 02:58, Nathan Wolf [email protected] wrote:

Thanks, tracking that as #582 https://github.com/elBukkit/MagicPlugin/issues/582

Really a shame, though.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/elBukkit/MagicPlugin/issues/579?email_source=notifications&email_token=AKMF5VNJXLL4T2VKB3WEP3TQLFJ2FA5CNFSM4IYLHOD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MTWEQ#issuecomment-534330130, or mute the thread https://github.com/notifications/unsubscribe-auth/AKMF5VIBMFKGX2QRWMUGXRTQLFJ2FANCNFSM4IYLHODQ .

GottaSlay avatar Sep 24 '19 00:09 GottaSlay