datasketch -Issue: #205: Merging (Identically Specified) MinHashLSH objects

Merging two MinHashLSH of the same length (num_perm).

Jan 20 '24 09:01 rupeshkumaar

@ekzhu I have raised a PR. I have tried to cover all the points that we had discussed. Please feel free to engage and let me know if any modification is required. Thank you!

Jan 20 '24 09:01 rupeshkumaar

@ekzhu Resolved the conversations. Can you please go through the changes. Thank you. Let me know if there are any other changes.

Jan 21 '24 06:01 rupeshkumaar

Could you also add "3.12" to the tested python version:

https://github.com/ekzhu/datasketch/blob/master/.github/workflows/test.yml#L11

Jan 22 '24 07:01 ekzhu

@ekzhu When will this commit be merged?

Feb 29 '24 01:02 junrae6454

@junrae6454 Still waiting for @rupeshkumaar's changes. Unless you want to help finishing this?

Mar 01 '24 06:03 ekzhu

Could you also add "3.12" to the tested python version:

https://github.com/ekzhu/datasketch/blob/master/.github/workflows/test.yml#L11

This is also done.

Mar 02 '24 06:03 rupeshkumaar

Could you also add "3.12" to the tested python version: https://github.com/ekzhu/datasketch/blob/master/.github/workflows/test.yml#L11

This is also done.

Thanks. Let me know when the changes are pushed

Mar 02 '24 07:03 ekzhu

Please do let me know, @ekzhu about the hashfunc for redis that I have asked. Thank you. Logging out for now. Once this is done I will push the changes.

Mar 02 '24 08:03 rupeshkumaar

@ekzhu Please review.

Mar 11 '24 06:03 rupeshkumaar

Also, to fix the tests failure for now, remove 3.12 from python version.

Mar 11 '24 18:03 ekzhu

Please review @ekzhu

Mar 12 '24 10:03 rupeshkumaar

@rupeshkumaar merged, thank you for the hard work!!

Mar 12 '24 15:03 ekzhu

@rupeshkumaar if you are interested, you can take a look at this issue #236 that broke the library for python 3.12

Mar 12 '24 15:03 ekzhu

Yeah, sure I will take a look. @ekzhu

Mar 12 '24 16:03 rupeshkumaar