eksctl icon indicating copy to clipboard operation
eksctl copied to clipboard

Check if CallbackUrls can be omitted when creating a user pool client in identity provider tests

Open cPu1 opened this issue 4 years ago • 9 comments

The integration test for identity provider (integration/tests/identity_provider/identity_provider_test.go) sets some additional fields like CallbackUrls in the call to CreateUserPoolClient that may not be required. Revisit those fields and remove those that deem unnecessary, while ensuring the tests still pass.

cPu1 avatar Dec 14 '21 10:12 cPu1

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 14 '22 01:01 github-actions[bot]

@cPu1 can you add more details of the tests in question here? which test needs to be updated?

Himangini avatar Jan 18 '22 11:01 Himangini

@cPu1 can you add more details of the tests in question here? which test needs to be updated?

I have updated the description with the filename.

cPu1 avatar Jan 18 '22 12:01 cPu1

Low prio for now, worth revisiting in future at some point

Himangini avatar Jan 20 '22 13:01 Himangini

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Feb 20 '22 01:02 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Mar 23 '22 02:03 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Apr 23 '22 02:04 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 26 '22 02:05 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jun 26 '22 02:06 github-actions[bot]