python-quickbooks icon indicating copy to clipboard operation
python-quickbooks copied to clipboard
verified publisher icon ej2

Back / pylint / flake8

Open pvizeli opened this issue 3 years ago • 4 comments

Hi @ej2

Is that an option to contribute CI helpers for github actions including better and automated code quality:

  • Black
  • pylint
  • flake8

For this project?

pvizeli avatar Aug 03 '22 11:08 pvizeli

Sure thing!

ej2 avatar Aug 03 '22 13:08 ej2

You have pip installer and pip files in this repository which does not make sense to have in a project like this. Can I also clean that to prevent black/lint issues on unnecessary files?

Once my open PR is merged, I make a new PR. All open PRs have to rebase and can't be merged after that.

pvizeli avatar Aug 03 '22 14:08 pvizeli

Do you want also to add secrets for real API tests or only run the unit test without a real connection?

pvizeli avatar Aug 04 '22 12:08 pvizeli

Probably not. Just run the unit test.

ej2 avatar Aug 05 '22 18:08 ej2