python-egnyte icon indicating copy to clipboard operation
python-egnyte copied to clipboard
verified publisher icon egnyte

Audit Report Bug Fixes

Open Andrew-Woodford opened this issue 7 years ago • 3 comments

Could not delete audit reports via the python SDK for two reasons:

  1. AuditReport class used the default Resource delete function. In the AuditReport class, this causes the 'job' endpoint to be used rather than the 'login'/'file'/etc endpoint with the complete url.
  2. When an audit report is deleted it returns a 204 HTTP status. Currently the check_response function only accepts a 200 code and hence was throwing an exception.

I have implemented fixes to both functions. Would advise a wider catch on HTTP status codes to include all 2XX codes.

Andrew-Woodford avatar Sep 07 '18 10:09 Andrew-Woodford

Why was this never merged?

skamensky avatar Jul 23 '19 22:07 skamensky

No idea unfortunately, never got a response after putting up the pull request. Not looked at the API recently so don’t know if it’s changed, but feel free to use the changes.

Andrew-Woodford avatar Jul 23 '19 23:07 Andrew-Woodford

Did you ever end up integrating with Egnyte? What was your experience? If you wouldn't mind shooting me an email to my thowaway account [email protected] I'd appreciate it :)

skamensky avatar Jul 24 '19 00:07 skamensky