egg-core icon indicating copy to clipboard operation
egg-core copied to clipboard

add middleware module type assertion

Open bung87 opened this issue 3 years ago • 1 comments

Checklist
  • [ ] npm test passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines
Affected core subsystem(s)
Description of change

ensure middleware export function

bung87 avatar Mar 30 '22 12:03 bung87

Codecov Report

Merging #241 (fe4c098) into master (91c04cc) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          19       19           
  Lines        1181     1182    +1     
  Branches      207      207           
=======================================
+ Hits         1178     1179    +1     
  Misses          3        3           
Impacted Files Coverage Δ
lib/loader/mixin/middleware.js 96.77% <100.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91c04cc...fe4c098. Read the comment docs.

codecov[bot] avatar Mar 30 '22 15:03 codecov[bot]

still missing the test case

fengmk2 avatar Dec 19 '22 05:12 fengmk2

sorry for that, I tried at that time, but fails, now I dont use nodejs anymore. I dont mind close this or what ever.

bung87 avatar Dec 19 '22 05:12 bung87