eggheads
Find a way to report SSL connection failures (more) accurately
| Trac | Data |
|---|---|
| Ticket | 86 |
| Reported by | Robby- |
| Status | new |
| Component | Core |
| Priority | minor |
| Milestone | 1.8.0 |
| Keywords | ssl connect connection failure |
| Version | 1.8.0 CVS |
Find a way to report SSL connection failures (more) accurately. For example, in cases when a server is down ("Connection refused"), a message as "Failed connect to
(TLS negotiation failure)" is misleading and distracts from the actual problem/issue.
I didnt check older versions of eggdrop, but with current eggdrop 1.9rc3, eggdrop connects to an ssl port the same way as it does to a non-ssl ports, via https://github.com/eggheads/eggdrop/blob/d01a34e163c47641eb9516ed918699b8822a7855/src/mod/server.mod/servmsg.c#L1992 the ssl handshake https://github.com/eggheads/eggdrop/blob/d01a34e163c47641eb9516ed918699b8822a7855/src/mod/server.mod/servmsg.c#L2009 is only done, if open_telnet_raw() was successful. And indeed, in my test, a connect to a ssl port results into the logging of Connection Refused:
.jump 127.0.0.1 +1234
[04:05:14] #-HQ# jump 127.0.0.1 +1234
Jumping servers......
[04:05:15] Trying server 127.0.0.1:+1234
[04:05:15] net: open_telnet_raw(): idx 2 host 127.0.0.1 ip 127.0.0.1 port 1234 ssl 1
[04:05:15] net: attempted socket connection refused: 127.0.0.1:1234
[04:05:15] Failed connect to 127.0.0.1 (Connection refused)
Please check if this Issue is obsolete by events and could be closed.