stack-overflow-copy-paste icon indicating copy to clipboard operation
stack-overflow-copy-paste copied to clipboard

refactor(getQueryStringParam): Escape all regex special characters in…

Open boyandim opened this issue 9 years ago • 2 comments

… the name parameter.

Currently the method is escaping only for the "[" and "]". The main idea is to escape all special characters that can be used in the regex expression itself.

boyandim avatar Apr 23 '16 22:04 boyandim

Current coverage is 100.00%

Merging #24 into master will not affect coverage as of 9c890e3

@@            master     #24   diff @@
======================================
  Files            7       7       
  Stmts           26      26       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             26      26       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 9c890e3

Powered by Codecov. Updated on successful CI builds.

codecov-io avatar Apr 23 '16 22:04 codecov-io

Hi! Thanks for the contribution! A few things:

  1. The commit message subject is too long. Could you shorten that a bit?
  2. Could you add a test or two for your improved functionality?

Thanks!

kentcdodds avatar Apr 23 '16 22:04 kentcdodds