volare icon indicating copy to clipboard operation
volare copied to clipboard

Please add a way to specify the verify= argument to httpx.Client

Open fisherdog3 opened this issue 1 year ago • 1 comments

Description

If a non-standard certificate is needed, eg on a corporate network, volare will not work. Reports not connected to the internet with ls-remote. Httpx does not seem to care about the system SSL certs in the usual search dirs but I could be mistaken. Other software which would be affected, conda and pip, do not have any issue connecting as I have installed the required cert. I was able to workaround by rebuilding with the verify= argument in the Client constructor.

Expected Behavior

Should perform an ls-remote

Relevant command

volare ls-remote

Relevant log output

You don't appear to be connected to the Internet. ls-remote cannot be used.

fisherdog3 avatar May 07 '24 18:05 fisherdog3

Supporting my claim that HTTPX is not using my certs: https://github.com/encode/httpx/issues/302

fisherdog3 avatar May 07 '24 19:05 fisherdog3

That would've been a nightmare to implement so what I did was: You can now pip3 install volare[truststore] which will use your computer's trust store.

donn avatar May 23 '24 16:05 donn

Can you confirm this works for you?

donn avatar May 23 '24 16:05 donn

This is working for me and I can ls-remote right after install.

fisherdog3 avatar May 30 '24 14:05 fisherdog3

Glad to hear! Feel free to open another issue if you run into anything else. :)

donn avatar May 30 '24 14:05 donn