mpw_precheck icon indicating copy to clipboard operation
mpw_precheck copied to clipboard

add version check to precheck

Open jeffdi opened this issue 2 years ago • 7 comments

Add check to precheck that would compare its version to a version tag posted in a known file location on the precheck git repo.

If the current version is behind, post a warning (minimally) with instructions on how to update (e.g. make precheck).

jeffdi avatar Sep 14 '23 22:09 jeffdi

Perhaps this should be a hard failure.

jeffdi avatar Sep 14 '23 22:09 jeffdi

@jeffdi I think this check might be better to be implemented in the user project's makefile, as the makefile is responsible for the user's environment, and is aware of which tag the user is currently using.

We could print a warning that the precheck version is incorrect and exit, and provide the user with the target they can run to update precheck (which is make precheck)

marwaneltoukhy avatar Sep 18 '23 10:09 marwaneltoukhy

@marwaneltoukhy i think that misses the objective. we want precheck to check its version against the current available. the point is not to lock in on a tag, but to enable us to roll out a new version and users will automatically be prompted to update the next time they run, regardless of the version of caravel_user_project they started their project with (which can be behind in many cases).

jeffdi avatar Sep 19 '23 04:09 jeffdi

there is never a case where a user should be using an old version of precheck.

jeffdi avatar Sep 19 '23 04:09 jeffdi

PR pending - still needs final review

jeffdi avatar Jan 24 '24 16:01 jeffdi

create new version of user flow with the proposed changes in the PR.

jeffdi avatar Feb 28 '24 16:02 jeffdi