speaker: emit errors for fd failures

[andyholmes]

When Spiel fails to open/close pipes in spiel_speaker_speak(), emit utterance-error and return early.

[eeejay]

This fails in CI

[andyholmes]

This fails in CI

Yeah, I'm really not sure why g_close() is a missing symbol :confused:

I guess I'll just implement returning a GError manually, it's not a ton of code.

[eeejay]

Also, is there a test you can add?

[andyholmes]

Also, is there a test you can add?

Hmm, that's a good question. I'm not sure how to make an open() or close() call fail, other than maybe some simple wrappers with #ifdef SPIEL_TEST in them or something.

[andyholmes]

Also, is there a test you can add?

Hmm, that's a good question. I'm not sure how to make an open() or close() call fail if that's what you mean, other than maybe some simple wrappers with #ifdef SPIEL_TEST in them or something.

[eeejay]

This looks like its still failing on tests. Do you want to rebse and give the PR another chance?

[andyholmes]

Hmm, not sure why it's timing out, and I can't reproduce locally.