google-maps-services-ruby icon indicating copy to clipboard operation
google-maps-services-ruby copied to clipboard
verified publisher icon edwardsamuel

Add GoogleMapsService::Error::NotFoundError

Open jguthrie100 opened this issue 8 years ago • 2 comments

  • When doing a directions search, if you enter an invalid address (i.e. 'dsadsfdfdscfrcerf, Tanzania'), a GoogleMapsService::Error::NotFoundError is raised

jguthrie100 avatar Jun 03 '17 17:06 jguthrie100

I found that entering a bad address in the directions API just returns a standard ApiError. I thought it would be nice to have something a bit more specific

(https://developers.google.com/maps/documentation/javascript/directions#DirectionsStatus)

jguthrie100 avatar Jun 03 '17 17:06 jguthrie100

Coverage Status

Coverage remained the same at 100.0% when pulling 93151a3b0caffd2ae6d6c77675466892889e8f3f on jguthrie100:add_not_found_error into 46746fd72e90c75855baa88aee04e41c84ff32c9 on edwardsamuel:master.

coveralls avatar Jun 03 '17 17:06 coveralls