eduardok
Remove 1000 char xattr limit
We need to access xattrs much bigger than 1000, up to the size allowed by the filesystem.
@crrodriguez please have a look at the failing tests - to my understanding the tests should still all be green. In addition adding a test for xattr wiht more then 1000 chars would be a good thing. THX
Please try this code instead: https://github.com/eduardok/libsmbclient-php/tree/edtests
Please try this code instead: https://github.com/eduardok/libsmbclient-php/tree/edtests
This patch is the same thing I had before, but avoided posting it do the different paths needed for old PHP versions, should do exacmle the same thing.
Please try this code instead: https://github.com/eduardok/libsmbclient-php/tree/edtests
This patch is the same thing I had before, but avoided posting it do the different paths needed for old PHP versions, should do exacmle the same thing.
Not sure what you mean by exactly the same since this pull request's code (https://github.com/eduardok/libsmbclient-php/pull/76/commits/b8137f6617b14ce69d4992a136063439f8bf4c7e) is quite different from the one I pointed you to (https://github.com/eduardok/libsmbclient-php/commit/565d0afd3201b7ba797ee195fb801fb6909a45bb). It uses no ALLOCA_FLAG/do_alloca, handles different PHP versions, and passes CI (https://travis-ci.org/github/eduardok/libsmbclient-php/builds/748486644).
Please try this code instead: https://github.com/eduardok/libsmbclient-php/tree/edtests
This patch is the same thing I had before, but avoided posting it do the different paths needed for old PHP versions, should do exacmle the same thing.
Not sure what you mean by exactly the same since this pull request's code (b8137f6) is quite different from the one I pointed you to (565d0af). It uses no ALLOCA_FLAG/do_alloca, handles different PHP versions, and passes CI (https://travis-ci.org/github/eduardok/libsmbclient-php/builds/748486644).
Sorry if I was unclear, I mean an early version of this request that isn't online was very similar to yours.
We need to access xattrs much bigger than 1000, up to the size allowed by the filesystem.
Any idea of what size is needed ? because dyn alloc doesn't work anymore :(
We need to access xattrs much bigger than 1000, up to the size allowed by the filesystem.
Any idea of what size is needed ? because dyn alloc doesn't work anymore :(
64k