editor-blocks icon indicating copy to clipboard operation
editor-blocks copied to clipboard

Fix wrapper issue and updated gitignore

Open tasnimAlam opened this issue 6 years ago • 2 comments

tasnimAlam avatar Apr 10 '19 15:04 tasnimAlam

Hi @tasnimAlam,

It looks like your changes do a lot more than just fix the issue you raised in #7, would you be able to limit your pull request to the fix? Also could you please confirm it's backward-compatible if a user is already using the wrapper block.

Thanks!

DannyCooper avatar Apr 11 '19 12:04 DannyCooper

Hello,

Thanks for your reply. Sure, I'll change my code. We're developing a Gutenberg plugin named "Essential Blocks". I had similar problem like this before. I solved the problem this way. So far I didn't face any issues. I'll check its backward compatibilities.

Best regards, Tasnim Alam

On Thu, Apr 11, 2019, 6:04 PM Danny Cooper [email protected] wrote:

Hi @tasnimAlam https://github.com/tasnimAlam,

It looks like your changes do a lot more than just fix the issue you raised in #7 https://github.com/editorblocks/editor-blocks/issues/7, would you be able to limit your pull request to the fix? Also could you please confirm it's backward-compatible if a user is already using the wrapper block.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/editorblocks/editor-blocks/pull/8#issuecomment-482086679, or mute the thread https://github.com/notifications/unsubscribe-auth/AV0t75QTyUpMB_gOaIl4w7CzMh4UdrWzks5vfyTcgaJpZM4cnq9D .

tasnimAlam avatar Apr 11 '19 12:04 tasnimAlam