embed icon indicating copy to clipboard operation
embed copied to clipboard
verified publisher icon editor-js

not working with Typescript

Open taishi55 opened this issue 3 years ago • 10 comments

I tried to use this plugin with typescript. It seems not working.

I look forward to hearing some advice.

So far, I tried npm i --save-dev @types/editorjs__embed and adding declare module '@editorjs/embed'; on external.d.ts

taishi55 avatar Oct 05 '22 03:10 taishi55

Same here! In typescript the embed block is not shown in the menu.

thmarx avatar Dec 05 '22 08:12 thmarx

same here

ludusrusso avatar Dec 14 '22 13:12 ludusrusso

Same here

TheAlphamerc avatar Dec 30 '22 05:12 TheAlphamerc

same here

legezam avatar Jan 11 '23 19:01 legezam

Aah, it works it just doesn't have a UI. This issue can be closed. If you want to trigger embed, go to youtube, and paste the url of a video from the address bar (not the embed code!) into a plain paragraph block and it will work automagically. Perhaps it would be beneficial to make this a bit more clear in the readme or somewhere.

legezam avatar Jan 11 '23 19:01 legezam

Yeah, and having a UI would also be great.

TheAlphamerc avatar Jan 12 '23 06:01 TheAlphamerc

haha thanks for the comment. I would never have guessed. and inline toolbar not working

RedLionHeart avatar Feb 07 '23 11:02 RedLionHeart

It does not work if the link includes the channel id. For example, https://www.youtube.com/watch?v=ypa_7HT2UGQ&ab_channel=NotaLoop

notaloop0000 avatar Mar 12 '23 11:03 notaloop0000

Same here, Embed does not show in the menu.

kimyvgy avatar Apr 27 '23 02:04 kimyvgy

Same here

mohamedsahel avatar Jul 14 '23 14:07 mohamedsahel

Meanwhile it should work with typescript.

Same here, Embed does not show in the menu.

This is not a bug. It a feature. Just add the url in Paragraph.

Sozialarchiv avatar Oct 12 '24 13:10 Sozialarchiv

Resolved by https://github.com/editor-js/embed/pull/128

neSpecc avatar Oct 12 '24 13:10 neSpecc