constellation icon indicating copy to clipboard operation
constellation copied to clipboard

deps: update bazel (core)

Open renovate[bot] opened this issue 1 year ago • 2 comments

This PR contains the following updates:

Package Type Update Change
bazel minor 7.2.1 -> 7.3.1
gazelle bazel_dep minor 0.38.0 -> 0.39.0
rules_go bazel_dep minor 0.49.0 -> 0.50.1

[!WARNING] Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

bazelbuild/bazel (bazel)

v7.3.1

Compare Source


Release Notes:

v7.3.0

Compare Source


Release Notes:


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Sep 19 '24 11:09 renovate[bot]

Deploy Preview for constellation-docs canceled.

Name Link
Latest commit 5775141abefa55cecae146acbce4a44a70d86ba7
Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/67092addc1a5d2000829893b

netlify[bot] avatar Sep 19 '24 11:09 netlify[bot]

There's an incompatibility between rules_nixpkgs and the new Bazel version:

(22:51:34) ERROR: /home/runner/.cache/bazel/_bazel_runner/4bd40f54087e3e1007fe1e344c299a60/external/nixpkgs_cc_toolchain/BUILD.bazel:154:31: syntax error at '%': expected expression
cc_toolchain_config(
    name = "local",
    cpu = "k8",
    compiler = "compiler",
    toolchain_identifier = "local",
    # ...
    coverage_compile_flags = ["--coverage"],
    coverage_link_flags = ["--coverage"],
    supports_start_end_lib = True,
    extra_flags_per_feature = %{extra_flags_per_feature}, # <---
)

As far as I can tell, there's a missing template parameter extra_flags_per_feature, which was only added in https://github.com/tweag/rules_nixpkgs/commit/2e0ba5493bc07c40b365bd07334a6477754a6062. Waiting for [email protected] should resolve this.

burgerdev avatar Sep 24 '24 06:09 burgerdev

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate[bot] avatar Oct 07 '24 08:10 renovate[bot]

@msanft I'd rather avoid unreleased versions - do we need the Bazel update that much?

I'd like to have it due to Bazel 7.3 being available in nixpkgs. The commit history since 0.12 looks fine to me. Do you have concrete concerns with this besides general instabilities potentially caused by non-release versions?

msanft avatar Oct 07 '24 08:10 msanft

Renovate will then try to upgrade to non-released versions, too. Can we somehow specify the Bazel minor version to use in the dev shell instead (which is, I guess, what you're after)?

burgerdev avatar Oct 07 '24 08:10 burgerdev

Renovate will then try to upgrade to non-released versions, too. Can we somehow specify the Bazel minor version to use in the dev shell instead (which is, I guess, what you're after)?

I'd find it acceptable to mark this as an exclusion for Renovate for the time being, but am also fine with sticking to release versions. I asked the rules_nixpkgs folks about their schedule for 0.13 and will report back. Setting the Bazel minor version in Nix is possible, but doesn't really apply for this case, as Bazel 7.2.x is and will not be packaged in Nix due to lockfile incompatibilities which are only fully resolved in 7.3.x (which will land in nixpkgs main soon, only pending some nits)

So it's really only a problem for people consuming Bazel from Nix (i.e. me), that I'd like to fix eventually. But definitely non-blocking.

I'll wait for a 0.13 release and then change the non-release commit accordingly here.

msanft avatar Oct 07 '24 08:10 msanft