edgedb-ui icon indicating copy to clipboard operation
edgedb-ui copied to clipboard

Selecting and coping data out of UI.

Open izakfilmalter opened this issue 3 years ago • 6 comments

Text selection leaves a lot to be desired currently.

image

  • Can't select the id to copy it from the row. Would be nice to have the copy button like on the docs for the id column. image
  • Can't select any of the properties or values when you expand a row into it's object. Again, would be sick to have the copy button to copy the object to json.

izakfilmalter avatar Aug 16 '22 09:08 izakfilmalter

@jaclarke James, let's take a look at this.

1st1 avatar Aug 16 '22 19:08 1st1

Also need to improve text selection here. Can't select anything.

image

After looking at the css for a bit, it looks like .app_app has user-select: none; on it. I think this is a bad move. Users want to select things. I get disabling select on buttons so that you don't select the button text. This top of dom blocking of text selection is user hostile.

The copy buttons here are great, but they are not a substitute for selecting text. Has to be both and.

izakfilmalter avatar Aug 18 '22 11:08 izakfilmalter

I greatly appreciate this small change. Though, in the way it was introduced on this pull request make buttons inside the interface be on a selected state when clicking on them.

On Chrome v103, MacOS 12.4, when creating a new entry that has a boolean column, when clicking on either "true" or "false" the button becomes selected for example.

pedropalhari avatar Aug 18 '22 22:08 pedropalhari

Ya I could probably update the pr to block selection on buttons.

izakfilmalter avatar Aug 19 '22 00:08 izakfilmalter

Came here for this issue. I constantly find myself disabling the user-select: none.

Right now I find myself wanting to select text in

  • the REPL history like @izakfilmalter said

  • The data explorer expansion CleanShot 2022-08-26 at 15 02 14@2x

  • the changes review modal image

But it probably should be enabled everywhere 😃

dotlouis avatar Aug 26 '22 13:08 dotlouis

We're working on enabling copying in the UI. We'll likely backport the feature partially to 2.x.

1st1 avatar Aug 26 '22 20:08 1st1