fix ipv6 connection issues

Open zachary822 opened this issue 1 year ago • 2 comments

Addresses #486

Uses socket.getaddrinfo to get address family from provided host and port for the blocking client. This addresses the previous issue that only ipv4 clients were allowed.

May 04 '24 07:05 zachary822

All commit authors signed the Contributor License Agreement.

May 04 '24 07:05 gel-data-cla[bot]

I tested this. I was able to connect to a remote edgedb instance over ipv6 with these changes. Thanks for the PR!

May 11 '24 14:05 cmr-a

Thanks for the PR! However, I think we should try to connect to all resolved addresses and use the first one that succeeded, in the same way as asyncio does. I submitted #499 (with your commit) to also fix IPv6.

May 29 '24 00:05 fantix