padelpy icon indicating copy to clipboard operation
padelpy copied to clipboard
verified publisher icon ecrl

Clean up unnecessary files after keyboard interrupt

Open maclandrol opened this issue 4 years ago • 2 comments

This PR cleans up temp files that remains after a keyboard interrupt.

I was also wondering whether you are willing to do a conda-forge release of this package.

Thanks

maclandrol avatar Dec 13 '21 17:12 maclandrol

Hi @maclandrol,

Very nice catch, I had not considered this use case. Just a few comments before we merge:

  • Please update the version, we'll release this as 0.1.12 (versioning found here)
  • I can't imagine a unit test is needed, the implementation is simple enough

As for a conda-forge release: yes, this is something we'd like to do! I'll look into the process of releasing.

Thanks, Travis

tjkessler avatar Dec 23 '21 02:12 tjkessler

Hi @tjkessler, I just created a feedstock for padelpy on conda-forge and added you as the package maintainer.

I am currently waiting for tests to pass and the "0.1.12" version to adjust a few things like the path to the license. The manifest should help packaging the license file into the source code.

maclandrol avatar Dec 23 '21 15:12 maclandrol

Finally getting around to this - keep me posted on updates regarding Conda!

tjkessler avatar Sep 08 '22 22:09 tjkessler