fdb icon indicating copy to clipboard operation
fdb copied to clipboard

Wipe refactoring + Toc/Remote Wipe

Open danovaro opened this issue 6 months ago • 2 comments

Description

The aim is to unify the WipeVisitor and expose some catalogue and store methods responsible for the backend-specific checks and removal actions.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈 https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-158

danovaro avatar Aug 02 '25 20:08 danovaro

Codecov Report

:x: Patch coverage is 77.69886% with 157 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.34%. Comparing base (6572460) to head (8ac4d7d). :warning: Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
src/fdb5/toc/TocCatalogue.cc 79.00% 21 Missing :warning:
src/fdb5/toc/TocStore.cc 77.50% 18 Missing :warning:
src/fdb5/api/local/WipeVisitor.cc 85.95% 17 Missing :warning:
src/fdb5/daos/DaosStore.cc 0.00% 15 Missing :warning:
src/fdb5/remote/server/StoreHandler.cc 85.88% 12 Missing :warning:
src/fdb5/daos/DaosCatalogue.cc 0.00% 10 Missing :warning:
src/fdb5/message/MessageArchiver.cc 0.00% 8 Missing :warning:
src/fdb5/toc/TocCommon.cc 74.07% 7 Missing :warning:
src/fdb5/api/RemoteFDB.cc 70.00% 6 Missing :warning:
src/fdb5/remote/Messages.cc 0.00% 6 Missing :warning:
... and 14 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #158       +/-   ##
============================================
- Coverage    74.53%   62.34%   -12.19%     
============================================
  Files          333      324        -9     
  Lines        20379    19046     -1333     
  Branches      2088     2031       -57     
============================================
- Hits         15190    11875     -3315     
- Misses        5189     7171     +1982     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Aug 05 '25 05:08 codecov-commenter

One thing I noticed is that the codecov coverage went down quite a bit. This may be due to the changes in the DAOS tests. Double check this and think about introducing new tests for the coverage of the new interface (I appreciate that those changes are preliminary and a full coverage may first be achieved with the final commits before merging onto develop)

tbkr avatar Aug 19 '25 15:08 tbkr

Replacing this PR with https://github.com/ecmwf/fdb/pull/184

ChrisspyB avatar Dec 02 '25 13:12 ChrisspyB