react-times icon indicating copy to clipboard operation
react-times copied to clipboard

In 12-hour mode (material theme), hour should read "12" instead of "00"

Open jordanmhiller opened this issue 7 years ago • 3 comments

In English in 12-hour time, it's customary to show the hour as "12" instead of "00" with both AM and PM. E.g.: https://simple.wikipedia.org/wiki/12-hour_clock

00:05 (24 hour) = 12:05AM (currently displays as 00:05AM) 12:05 (24 hour) = 12:05PM (currently displays as 00:05PM)

This is in the material theme.

On the classic theme, the drop-down doesn't have this issue (it shows 12:30PM), but once you select a time the display reverts to "00:30PM".

jordanmhiller avatar Nov 30 '18 21:11 jordanmhiller

I'm glad it's a known issue! I thought it was something I was doing wrong.

mjperales avatar Aug 29 '19 19:08 mjperales

If you're interested, I fixed the issue on my project by going to lib/common/TimePicker.js and updating line 566.

mjperales avatar Aug 29 '19 19:08 mjperales

@mjperales - do you have a PR or gist for the change?

ram4git avatar Nov 04 '19 22:11 ram4git