transformer [ISSUE 606] Discard signatures from jar file that was mutated

See https://github.com/eclipse/transformer/issues/606

Jul 05 '24 12:07 jluehe

Also, please update the PR to have a proper title and initial comment.

Jul 05 '24 13:07 bjhargrave

@bjhargrave, please let me know if the proposed changes look good to you now, or if you have any further comments, which I will be happy to address. Thank you!

Aug 07 '24 14:08 jluehe

@bjhargrave, thank you for your meaningful code-review comments: they are very much appreciated! Third time's a charm :)

Aug 15 '24 14:08 jluehe

Thank you, @bjhargrave, for your latest comments! I think I have addressed them all, including adding an integration test for the plugin (https://github.com/eclipse/transformer/pull/607/commits/94e34c859ba7fadf5ec0d2da3e183c8a8dcb88ea)! Please let me know!

Aug 16 '24 20:08 jluehe

Thank you, @bjhargrave! Made your suggested changes by renaming strip-signatures to stripSignatures, and removing redundant assertNotNull ...

Aug 20 '24 20:08 jluehe

Thanks for all your work on this!

Aug 20 '24 20:08 bjhargrave

Thank you, @bjhargrave! It has been a really rewarding experience to work on this, and I hope to be able to make additional contributions to this project down the road! Thanks again for taking the time to review my PR iterations and providing such meaningful and thoughtful comments! On a separate note, do you think this feature would be worth a release? We currently have to "manually" strip signature files, and using the new command option would simplify things for us!

Aug 20 '24 21:08 jluehe

On a separate note, do you think this feature would be worth a release?

Ha, I was waiting for that question... Let me meditate on it.

Aug 20 '24 21:08 bjhargrave