tm4e icon indicating copy to clipboard operation
tm4e copied to clipboard

Unable to import as source project in PDE

Open RedeemerSK opened this issue 1 year ago • 4 comments

While doing some Eclipse development I ended up needing to see source code of 'org.eclipse.tm4e.ui' plugin. As previously with other plugins, I expected to be able to just import as source project from plugins view. In case this expectation is unjustified, let me know, I'm no expert in Eclipse plugins development.

Project was however not imported with source code, but just with binary JAR of itself (as a referenced library of created project).

Eclipse PDE Latest (2025-03 M1 (4.35.0 M1)), fully updated. org.eclipse.tm4e.ui version: 0.14.1.202412182118 (atm latest from https://download.eclipse.org/tm4e/snapshots/). Target platform set to "Running platform".

I can only guess that "Eclipse-SourceReferences" in MANIFEST.MF is used when importing project for plugin, and the "path" there seems ok to me. Only the whole MANIFEST.MF file is not formatted according to spec, but it may not be the cause.

RedeemerSK avatar Jan 12 '25 20:01 RedeemerSK

TBH I have no idea. @mickaelistria WDYT?

sebthom avatar Jan 12 '25 22:01 sebthom

Import As > Source Project would only work if you have the source bundle available too IIRC. If you want to import using the Eclipse-SourceReferences (which is best), you should try "Import As > Project from Repository...".

mickaelistria avatar Jan 13 '25 07:01 mickaelistria

I've open https://github.com/eclipse-pde/eclipse.pde/pull/1556 to hopefully provide better guidance from the plug-in view.

mickaelistria avatar Jan 13 '25 07:01 mickaelistria

and also https://github.com/eclipse-pde/eclipse.pde/issues/1557 was one cause here.

mickaelistria avatar Jan 13 '25 07:01 mickaelistria

@mickaelistria Can we close this issue or is there anything we can do in TM4E?

sebthom avatar May 31 '25 19:05 sebthom

Yes, let's close it here.

mickaelistria avatar Jun 01 '25 20:06 mickaelistria