Javascript sparkplug-payload

Open alex-controlx opened this issue 4 years ago • 2 comments

I'm working on creating Typescript definitions and notices a few bugs.

https://github.com/eclipse/tahu/blob/77bdbe3bc373063aa82641e9059d30bfb878fa5b/javascript/core/sparkplug-payload/lib/sparkplugbpayload.js#L54 to be

PropertySetList = SparkplugPayload.lookup('org.eclipse.tahu.protobuf.Payload.PropertySetList'),

https://github.com/eclipse/tahu/blob/77bdbe3bc373063aa82641e9059d30bfb878fa5b/javascript/core/sparkplug-payload/README.md?plain=1#L12 to be

npm install sparkplug-payload

May 01 '22 14:05 alex-controlx

Hi, you might be interested in https://github.com/eclipse/tahu/pull/189

May 18 '22 17:05 ferm10n

I am. Thanks for pointing this out. It looks great, let me know if I can contribute into your pull request.

Below is a link to my conversion (if its' helpful). https://gist.github.com/alex-controlx/f59d54443b8efdd90dcd1a7cd6c280e3

May 18 '22 23:05 alex-controlx