packages icon indicating copy to clipboard operation
packages copied to clipboard

Hawkbit: Use networking.k8s.io/v1 for Ingress if available

Open PSanetra opened this issue 4 years ago • 8 comments

This PR adds support for the v1 Ingress resource which is necessary for a deployment to Kubernetes 1.22.

PSanetra avatar Nov 08 '21 09:11 PSanetra

@laverman @kaizimmerm could any of you take a look at this

ctron avatar Nov 09 '21 08:11 ctron

helm-chart is not supported anymore?

zidex avatar Jul 20 '23 12:07 zidex

https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122

bulmust avatar May 30 '24 13:05 bulmust

I'm also waiting for this. Please merge this PR to keep supporting the helm-chart.

rondegroot avatar Jul 16 '24 14:07 rondegroot

I'm also waiting for this. Please merge this PR to keep supporting the helm-chart.

I give up and maintain it by myself.

By the way, you can add storage class under this line: storageClassName: {{ .Values.fileStorage.storageClass }} (Be careful to indent)

bulmust avatar Jul 16 '24 17:07 bulmust

Is this maintained? @bulmust do you have your own version public? Need to add custom serviceAccounts

paltaa avatar Aug 09 '24 19:08 paltaa

Is this maintained? @bulmust do you have your own version public? Need to add custom serviceAccounts

I do not publish my own helm chart to anywhere. By the way, this helm chart has a lot of problems like absence of serviceAccounts, storageClass etc, so as I understand this repo does not maintained anymore. You should also consider hawkbit microservice mode which is not compatible with this helm chart.

bulmust avatar Aug 12 '24 07:08 bulmust

Alright, thanks for the response! @bulmust, will just copy it and create our own version

paltaa avatar Aug 12 '24 13:08 paltaa

Sorry this didn't get attention for so long. @strailov @avgustinmm Any comments on this? It looks good to me. I guess it could make sense to merge this before the hawkbit 0.5.0 update PR.

@PSanetra In order to be able to merge this, the chart (patch) version needs to be updated in the Chart.yaml. This requires a prior git rebase, so that the change is based on the current chart version. Could you do that still? Or, if you don't mind, I could make that change and push to your PR branch (if that was enabled on PR creation).

calohmn avatar Sep 29 '24 10:09 calohmn

Commit merged via #550, available in chart version 1.6.1.

calohmn avatar Oct 02 '24 19:10 calohmn