mosquitto icon indicating copy to clipboard operation
mosquitto copied to clipboard

Let auth plugin handle if no username matched

Open kuldeepdhaka opened this issue 6 years ago • 1 comments

mosquitto_unpwd_check_default() should return MOSQ_ERR_PLUGIN_DEFER instead MOSQ_ERR_AUTH if no username matched so that auth plugin can handle it.

According to docs: "If password_file, or acl_file are used in the config file alongsize auth_plugin, the plugin checks will run after the build in checks."

Fixes #1215

  • [ ] If you are contributing a new feature, is your work based off the develop branch?
  • [ ] If you are contributing a bugfix, is your work based off the fixes branch?
  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you successfully run make test with your changes locally?
  • [ ] Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • [x] Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.

kuldeepdhaka avatar Mar 30 '19 21:03 kuldeepdhaka

This possibly needs changing, thanks for noting it. There is no way I can accept any changes to this without extensive tests though.

ralight avatar Apr 11 '19 10:04 ralight