lemminx icon indicating copy to clipboard operation
lemminx copied to clipboard

Document that `doSave()` can be called before `start()` for IXMLExtension

Open datho7561 opened this issue 5 years ago • 2 comments

Clarify that the doSave() method can be called before the start() method in the documentation for IXMLExtension. For instance, this is done in the XMLAssert tests to test LemMinX extensions.

datho7561 avatar Jan 12 '21 18:01 datho7561

I wonder more and more if we must remove this doSave and have a participant which tracks didOpen, didSave, etc and have a participant which tracks settings (see WorkspaceService PR did by @mickaelistria https://github.com/eclipse/lemminx/pull/958)

@rzgry I think you could be interested too by this issue since you are using doSave too.

angelozerr avatar Jan 12 '21 18:01 angelozerr

We currently use doSave just for updating the settings and keeping them updated. https://github.com/OpenLiberty/liberty-language-server/blob/master/lemminx-liberty/src/main/java/io/openliberty/lemminx/liberty/LibertyExtension.java#L52

A setting participant that keeps track of settings and is notified whenever the settings are changed would be useful.

rzgry avatar Jan 12 '21 19:01 rzgry