kapua icon indicating copy to clipboard operation
kapua copied to clipboard

Break job engine to rest api dependency

Open dseurotech opened this issue 1 year ago • 2 comments

This PR breaks the dependency that job-engine had to the rest-api, reorganising the commons-rest modules into a more structured commons-jersey modules (splitted in to rest and web submodules), that contain all the necessary components to handle jersey-based services (be they web apps or rest apis).

Breaking changes!

Also absorbs: https://github.com/eclipse/kapua/pull/4017 This PR intends to clean up the internal dependencies between kapua modules. In most cases, it just cleans up the pom.xml files from dependencies which are already received transitively via maven (e.g.: if you already depend on the -internal module, it is implicit the dependence from the -api module). In a few cases data classes have been moved closer to the project that use them -e.g.: IsJobRunningMultipleResponse.java is specific to the job engine and does not need to be in the commons-rest-model module.

dseurotech avatar Jul 03 '24 08:07 dseurotech

Codecov Report

Attention: Patch coverage is 33.94495% with 72 lines in your changes missing coverage. Please review.

Project coverage is 16.63%. Comparing base (702bd78) to head (1435d79). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ommons/jersey/rest/model/IsJobRunningResponse.java 0.00% 12 Missing :warning:
...ersey/rest/model/IsJobRunningMultipleResponse.java 0.00% 9 Missing :warning:
...ommons/jersey/rest/filters/CORSResponseFilter.java 0.00% 7 Missing :warning:
...ommons/jersey/rest/model/MultipleJobIdRequest.java 0.00% 5 Missing :warning:
...apua/job/engine/client/JobEngineServiceClient.java 0.00% 5 Missing :warning:
...mmons/jersey/rest/errors/KapuaExceptionMapper.java 0.00% 4 Missing :warning:
...ersey/rest/errors/KapuaRuntimeExceptionMapper.java 0.00% 4 Missing :warning:
...esources/v1/resources/DeviceManagementBundles.java 0.00% 4 Missing :warning:
...rest/errors/KapuaDuplicateNameExceptionMapper.java 0.00% 3 Missing :warning:
.../resources/v1/resources/ServiceConfigurations.java 0.00% 3 Missing :warning:
... and 11 more
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4073      +/-   ##
=============================================
- Coverage      16.79%   16.63%   -0.17%     
  Complexity        22       22              
=============================================
  Files           2037     2029       -8     
  Lines          52835    52732     -103     
  Branches        4441     4437       -4     
=============================================
- Hits            8874     8772     -102     
+ Misses         43560    43558       -2     
- Partials         401      402       +1     
Files with missing lines Coverage Δ
...clipse/kapua/client/security/bean/AuthContext.java 0.00% <ø> (ø)
...ersey/rest/ExceptionConfigurationProviderImpl.java 0.00% <ø> (ø)
...kapua/commons/jersey/rest/JaxbContextResolver.java 0.00% <ø> (ø)
...commons/jersey/rest/KapuaCommonApiCoreSetting.java 100.00% <100.00%> (ø)
...ons/jersey/rest/KapuaCommonApiCoreSettingKeys.java 100.00% <100.00%> (ø)
...mmons/jersey/rest/KapuaSerializableBodyWriter.java 100.00% <ø> (ø)
...ipse/kapua/commons/jersey/rest/ListBodyWriter.java 100.00% <ø> (ø)
...ons/jersey/rest/MoxyJsonConfigContextResolver.java 100.00% <ø> (ø)
...e/kapua/commons/jersey/rest/RestApiErrorCodes.java 100.00% <ø> (ø)
...a/commons/jersey/rest/RestApiRuntimeException.java 100.00% <ø> (ø)
... and 150 more

... and 16 files with indirect coverage changes

codecov[bot] avatar Jul 03 '24 08:07 codecov[bot]

This PR has been superseded by https://github.com/eclipse-kapua/kapua/pull/4293 and can be closed when #4293 will be merged

Coduz avatar Sep 24 '25 13:09 Coduz