kapua icon indicating copy to clipboard operation
kapua copied to clipboard

Feat injectable auth types

Open Coduz opened this issue 1 year ago • 1 comments

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

Related Issue This PR fixes/closes {issue number}

Description of the solution adopted A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped.

Screenshots If applicable, add screenshots to help explain your solution

Any side note on the changes made Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]

Coduz avatar Jul 02 '24 08:07 Coduz

Codecov Report

Attention: Patch coverage is 30.05780% with 121 lines in your changes missing coverage. Please review.

Project coverage is 16.80%. Comparing base (d5b679e) to head (171b71c).

Files Patch % Lines
...cation/credential/shiro/CredentialServiceImpl.java 6.38% 44 Missing :warning:
...ial/handler/shiro/ApiKeyCredentialTypeHandler.java 25.92% 20 Missing :warning:
...l/handler/shiro/PasswordCredentialTypeHandler.java 33.33% 14 Missing :warning:
...tication/shiro/AuthenticationServiceShiroImpl.java 0.00% 10 Missing :warning:
...ication/credential/shiro/PasswordResetterImpl.java 14.28% 6 Missing :warning:
...ice/authentication/shiro/AuthenticationModule.java 50.00% 4 Missing :warning:
...ation/shiro/realm/UserPassAuthenticatingRealm.java 0.00% 4 Missing :warning:
...pse/kapua/service/user/steps/UserServiceSteps.java 0.00% 4 Missing :warning:
...apua/service/device/registry/steps/AclCreator.java 0.00% 2 Missing :warning:
...thentication/credential/CredentialXmlRegistry.java 0.00% 2 Missing :warning:
... and 8 more
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4072      +/-   ##
=============================================
+ Coverage      16.78%   16.80%   +0.01%     
  Complexity        22       22              
=============================================
  Files           2016     2019       +3     
  Lines          52361    52378      +17     
  Branches        4419     4415       -4     
=============================================
+ Hits            8787     8800      +13     
- Misses         43176    43180       +4     
  Partials         398      398              
Files Coverage Δ
.../service/authentication/credential/Credential.java 0.00% <ø> (ø)
...uthentication/credential/CredentialAttributes.java 0.00% <ø> (ø)
...ce/authentication/credential/CredentialStatus.java 100.00% <ø> (ø)
...ception/DuplicatedPasswordCredentialException.java 100.00% <ø> (ø)
...hentication/exception/PasswordLengthException.java 66.66% <ø> (ø)
...cation/credential/shiro/CredentialCreatorImpl.java 100.00% <ø> (ø)
...cation/credential/shiro/CredentialFactoryImpl.java 100.00% <ø> (ø)
...uthentication/credential/shiro/CredentialImpl.java 100.00% <100.00%> (ø)
.../credential/shiro/CredentialImplJpaRepository.java 40.00% <100.00%> (ø)
...ion/credential/shiro/CredentialListResultImpl.java 100.00% <ø> (ø)
... and 27 more

codecov[bot] avatar Jul 02 '24 09:07 codecov[bot]