kapua icon indicating copy to clipboard operation
kapua copied to clipboard

Convert XmlUtils to injectable collaborator

Open dseurotech opened this issue 1 year ago • 1 comments

Converts XMLUtil to a non-static class, built based on a JAXBContextProvider (without the need to set one on the fly).

dseurotech avatar Mar 22 '24 08:03 dseurotech

Codecov Report

Attention: Patch coverage is 12.79070% with 150 lines in your changes are missing coverage. Please review.

Project coverage is 21.01%. Comparing base (81a090d) to head (d24f583). Report is 2 commits behind head on develop.

:exclamation: Current head d24f583 differs from pull request most recent head 0db707f. Consider uploading reports for the commit 0db707f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4000      +/-   ##
=============================================
+ Coverage      16.87%   21.01%   +4.14%     
  Complexity        10       10              
=============================================
  Files           1989     1953      -36     
  Lines          51791    41451   -10340     
  Branches        4420     3801     -619     
=============================================
- Hits            8739     8711      -28     
+ Misses         42648    32336   -10312     
  Partials         404      404              
Files Coverage Δ
...a/broker/artemis/plugin/security/ServerPlugin.java 0.00% <ø> (ø)
...esourceLimitedServiceConfigurationManagerImpl.java 11.42% <100.00%> (ø)
...kapua/commons/event/JsonServiceEventMarshaler.java 60.00% <100.00%> (-15.00%) :arrow_down:
.../kapua/commons/event/XmlServiceEventMarshaler.java 80.00% <100.00%> (+5.00%) :arrow_up:
...java/org/eclipse/kapua/commons/util/ClassUtil.java 100.00% <100.00%> (ø)
.../java/org/eclipse/kapua/app/api/web/AppModule.java 87.50% <100.00%> (-2.50%) :arrow_down:
.../kapua/service/account/internal/AccountModule.java 94.44% <ø> (ø)
...ua/service/datastore/internal/DatastoreModule.java 58.33% <ø> (ø)
.../internal/DeviceManagementConfigurationModule.java 66.66% <ø> (ø)
.../service/device/registry/DeviceRegistryModule.java 82.85% <ø> (ø)
... and 36 more

... and 46 files with indirect coverage changes

codecov[bot] avatar Mar 22 '24 08:03 codecov[bot]

Ip review filed: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14226

Coduz avatar Apr 04 '24 13:04 Coduz

Ip review approved!

Coduz avatar Apr 10 '24 09:04 Coduz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (b073aaa) to head (0db707f). Report is 9 commits behind head on develop.

:exclamation: Current head 0db707f differs from pull request most recent head e9a4b74. Consider uploading reports for the commit e9a4b74 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #4000       +/-   ##
=============================================
- Coverage      16.85%       0   -16.86%     
=============================================
  Files           1987       0     -1987     
  Lines          51803       0    -51803     
  Branches        4422       0     -4422     
=============================================
- Hits            8733       0     -8733     
+ Misses         42666       0    -42666     
+ Partials         404       0      -404     

see 1987 files with indirect coverage changes

codecov-commenter avatar Apr 22 '24 14:04 codecov-commenter