Clickhouse Native(Binary) client

[smagellan]

Motivation:

PR for https://github.com/eclipse-vertx/vertx-sql-client/issues/923

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

[vietj]

what does native means here ? can we avoid using this word because it has a very precise meaning for Java

[smagellan]

@vietj, that's how authors call the protocol: https://clickhouse.tech/docs/en/interfaces/tcp/. Agree, it may confuse. I will remove 'native' from module name, packages and classes

[vietj]

alright, then can you rebase you PR against master ?

On Thu, Apr 22, 2021 at 7:21 PM Vladimir @.***> wrote:

@.**** commented on this pull request.

In pom.xml https://github.com/eclipse-vertx/vertx-sql-client/pull/931#discussion_r618599707 :

@@ -59,7 +59,7 @@ <jar.manifest>${project.basedir}/src/main/resources/META-INF/MANIFEST.MF</jar.manifest> <source.skip>true</source.skip>

• <testcontainers.version>1.12.4</testcontainers.version>

I was not able to start clickhouse testcontainer with 1.12.4. Should not be a problem since it is already upgraded in master: https://github.com/eclipse-vertx/vertx-sql-client/blob/master/pom.xml#L62

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/eclipse-vertx/vertx-sql-client/pull/931#discussion_r618599707, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXDCRMBH74C6JYTAIPR7LTKBLJ3ANCNFSM42WMBGPQ .

[vietj]

thanks!

On Thu, Apr 22, 2021 at 7:24 PM Vladimir @.***> wrote:

@vietj, that's how authors call the protocol: https://clickhouse.tech/docs/en/interfaces/tcp/. Agree, it may confuse. I will remove 'native' from module name, packages and classes

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[smagellan]

@vietj, I will try to rebase. My last attempt failed due to .github directory limitations, maybe I need to add extra git rebase options

[rawvoid]

@vietj @smagellan
Hi, Are there any new developments? Thanks.

[vietj]

this module needs to be rebased on laster master branch and then reviewed / merged

On Thu, Aug 26, 2021 at 5:21 AM aomsweet @.***> wrote:

@vietj https://github.com/vietj @smagellan https://github.com/smagellan Hi, Are there any new developments? Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse-vertx/vertx-sql-client/pull/931#issuecomment-906061740, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXDCWNE4PEJHHFODH2RITT6WXKFANCNFSM42WMBGPQ .

[rawvoid]

Thanks for the great work. I am looking forward to this.