org.eclipse.rap icon indicating copy to clipboard operation
org.eclipse.rap copied to clipboard

added ability to have pt in css for font sizes

Open fx-world opened this issue 1 year ago • 3 comments

I have no idea why the commit is "mknauer authored", that was not the case.

Also-by: Ralf Schlesinger [email protected] Also-by: Rico Scholz [email protected]

fx-world avatar Sep 24 '24 12:09 fx-world

Can one of the admins verify this patch?

eclipse-rap-bot avatar Sep 24 '24 12:09 eclipse-rap-bot

ok to test

ifurnadjiev avatar Oct 07 '24 11:10 ifurnadjiev

It's better to implement it in PropertyResolver.readFontSize(LexicalUnit) instead of PropertyResolver.readSingleLengthUnit. PropertyResolver.readSingleLengthUnit is used in other places like readDimension or readShadow, where pt does not make sense. Please add a test to org.eclipse.rap.rwt.internal.theme.css.PropertyResolver_Test.testFontSize().

ifurnadjiev avatar Oct 08 '24 08:10 ifurnadjiev