Ignore additional parameter

[laeubi]

Currently if one passes more parameters as the command accepts (e.g. a parameter was removed from the command), this suddenly leads to commands no longer being found as null is returned.

Instead now ignore additional parameters and simply continue the loop over the map.

[iloveeclipse]

But that would allow commands to start with unexpected number of commands?

[github-actions[bot]]

Test Results

 1 214 files   -   607   1 214 suites   - 607   1h 11m 41s ⏱️ - 18m 59s  7 734 tests ±    0   7 501 ✅  -     5  233 💤 +  5  0 ❌ ±0  16 242 runs   - 8 121  15 727 ✅  - 7 887  515 💤  - 234  0 ❌ ±0 

Results for commit 01a08d6c. ± Comparison against base commit ca298d67.

This pull request skips 5 tests.

org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl

:recycle: This comment has been updated with latest results.

[laeubi]

But that would allow commands to start with unexpected number of commands?

Can you explain what exactly is meant here? This method constructs a ParameterizedCommand that only contains parameters that are declared by the command, the passed in Map is no longer used.

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle. Therefore the following files need a version increment:

bundles/org.eclipse.core.commands/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From fbfb94638a941e0da1212dac31bd06519b034bca Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sat, 28 Dec 2024 15:23:21 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.core.commands/META-INF/MANIFEST.MF b/bundles/org.eclipse.core.commands/META-INF/MANIFEST.MF
index 29990cb8a3..cdb2e1b2ee 100644
--- a/bundles/org.eclipse.core.commands/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.core.commands/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.commands
-Bundle-Version: 3.12.200.qualifier
+Bundle-Version: 3.12.300.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.core.commands,
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

[laeubi]

Only API tools failure in linux GH action.