orb icon indicating copy to clipboard operation
orb copied to clipboard

[WARNING] Supported source version 'RELEASE_8' from annotation processor 'org.glassfish.corba.annotation.processing.ExceptionWrapperProcessor' less than -source '11'

Open tdferreira opened this issue 1 year ago • 4 comments

I'm getting the following error all over my maven build when trying to compile my project with JDK11, where I include glassfish-corba-orb:4.2.5 as a dependency:

[WARNING] Supported source version 'RELEASE_8' from annotation processor 'org.glassfish.corba.annotation.processing.ExceptionWrapperProcessor' less than -source '11'

Do you plan to fully support Java 11?

tdferreira avatar Mar 23 '24 01:03 tdferreira

Java 11+ is supported, but that warning is indeed annoying. If I'm not mistaken it's a little bit difficult to get rid of though.

arjantijms avatar Mar 23 '24 21:03 arjantijms

https://github.com/eclipse-ee4j/orb/blob/master/exception-annotation-processor/src/main/java/org/glassfish/corba/annotation/processing/ExceptionWrapperProcessor.java#L37

Does it have a major impact changing @SupportedSourceVersion(SourceVersion.RELEASE_8) to @SupportedSourceVersion(SourceVersion.RELEASE_11)?

tdferreira avatar Mar 23 '24 21:03 tdferreira

With current target (8) - SourceVersion.RELEASE_11 is unknown I think.

In next step one could ask Do you plan to fully support Java 17? or Do you plan to fully support Java 21? Using SourceVersion.RELEASE_11 would not prevent the warnings from javac.

But perhaps the comment (for issue resolved as Not an Issue) https://bugs.openjdk.org/browse/JDK-8037955?focusedId=13475725&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13475725 could be of help here. I take the liberty to quote it here:

This request stems from a mis-use of the API. The usage model in question is using the @SupportedSourceVersion annotation together with AbstractProcessor which reads the source version stored in that annotation. This pairing of the @SupportedSourceVersion with AbstractProcessor works well in the common case of a processor supporting a single source value independent of which version of the platform the processor is run on.

If the processor author needs a more nuanced behavior to compute the supported source version, then the getSupportedSourceVersion() method should be overridden to implement the logic in question.

It is possible to return, say, RELEASE_6 when running on JDK 6 and RELEASE_7 when running on JDK 7 without using reflection. Something like

if (SourceVersion.latest > RELEASE_6)
 return (SourceVersion.values())[RELEASE_6.ordinal()+1];
else
 return RELEASE_6

pzygielo avatar Mar 23 '24 21:03 pzygielo

Have we made a decision to drop support for JDKs less than 11?

On Mar 23, 2024, at 5:07 PM, Arjan Tijms @.***> wrote:

Java 11+ is supported, but that warning is indeed annoying. If I'm not mistaken it's a little bit difficult to get rid of though.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/eclipse-ee4j/orb/issues/159*issuecomment-2016603088__;Iw!!ACWV5N9M2RV99hQ!MJjCkaEyFEEzsfnm3z0kjQx1o7rUqPAe81jNiVEXl3MERFaf4nPEViUifa3N_aVO7yCVmSOYTbvNvIi3_2CszQD7u6Y$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AARPWYHNPAUURTNZDKWIHCDYZXVJLAVCNFSM6AAAAABFEGTF7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGYYDGMBYHA__;!!ACWV5N9M2RV99hQ!MJjCkaEyFEEzsfnm3z0kjQx1o7rUqPAe81jNiVEXl3MERFaf4nPEViUifa3N_aVO7yCVmSOYTbvNvIi3_2CsW4TahIY$. You are receiving this because you are subscribed to this thread.Message ID: @.***>

russgold avatar Jun 21 '24 16:06 russgold