che icon indicating copy to clipboard operation
che copied to clipboard

Verify functionality of each sample from devfile.io on Che

Open svor opened this issue 1 year ago • 11 comments

Is your task related to a problem? Please describe

Since we start using devfile.io as a default registry for Che samples, we have to make sure that everything declared in the devfiles works as expected with a default Che-code editor:

  • workspace can start;
  • dev container provides all needed tools to work with the sample project;
  • all declared commands work as expected;
  • check debugging (if it's possible);
  • try to run the sample project (if it's possible);
  • Check if the devfile has an https endpoint, see: https://github.com/eclipse/che/issues/22869#issuecomment-1983269642 and https://github.com/eclipse/che/issues/22864. This is needed to properly open the application url from the editor's popup on latest version of Chrome browser.

All samples are available on Che dogfooding instance

Here is the list of samples:

Devfile link Verified Assigned
.NET 5.0 :heavy_check_mark: @ibuziuk
.NET 6.0 :heavy_check_mark: @ibuziuk
.NET Core 3.1 :heavy_check_mark: @vitaliy-guliy
Angular :heavy_check_mark: @vitaliy-guliy
Django :heavy_check_mark: https://github.com/devfile-samples/python-django-ex/pull/1 @tolusha
Go Runtime :heavy_check_mark: https://github.com/devfile/registry/pull/357 @tolusha
Laravel :heavy_check_mark:https://github.com/devfile/registry/pull/349 @dkwon17
Maven Java @azatsarynnyy
Next.js :heavy_check_mark: https://github.com/devfile/registry/pull/347 @RomanNikitenko
Node.js Runtime @azatsarynnyy
Nuxt.js :heavy_check_mark: https://github.com/devfile/registry/pull/346 @RomanNikitenko
Open Liberty Gradle :heavy_check_mark:https://github.com/devfile/registry/pull/350 @dkwon17
Open Liberty Maven :heavy_check_mark:https://github.com/devfile/registry/pull/351 @dkwon17
Python :heavy_check_mark: https://github.com/devfile/api/issues/1524 @dmytro-ndp
Quarkus Java https://github.com/eclipse/che/issues/22906 @vinokurig
React :heavy_check_mark: @vinokurig
Spring Boot :heavy_check_mark: https://github.com/devfile/api/issues/1526 @dmytro-ndp
Svelte :heavy_check_mark: @svor
Universal Developer Image :heavy_check_mark: @svor
Vert.x Java :heavy_check_mark: @artaleks9
Vue :heavy_check_mark: @artaleks9
WebSphere Liberty Gradle :heavy_check_mark: @akurinnoy
WebSphere Liberty Maven :heavy_check_mark: @akurinnoy
WildFly :heavy_check_mark: @olexii4
WildFly Bootable Jar :heavy_check_mark: @olexii4

Describe the solution you'd like

In case some problem was detected, need to provide a PR with the fix into https://github.com/devfile/registry.

If it's a problem that required additional investigation, it's better to register an issue where the problem should be described.

Additional context

An example PR that contributed changes to the net 6.0 devfile: https://github.com/devfile/registry/pull/298

svor avatar Mar 06 '24 15:03 svor

PRs for .NET 5 and 6

  • https://github.com/devfile/registry/pull/312
  • https://github.com/devfile/registry/pull/298

ibuziuk avatar Mar 07 '24 11:03 ibuziuk

FYI:

  • ~~https://github.com/devfile/api/issues/1454 was resolved and probably we can bump devfile's schemaVersion to 2.2.2 in devfile.yaml files~~ New issue to track https://github.com/devfile/api/issues/1481
  • Here is a slack channel to ask any related questions: https://redhat.enterprise.slack.com/archives/C017YDKHQV6

svor avatar Mar 18 '24 09:03 svor

Vert.x Java

  • workspace runs, but Unable to resolve nonexistent file in the project tree:

vertx-unable-resovle-file

  • needed tools are provided
  • commands: -- mvn-package -> build fail:

vertx-build-mvn-package-error

-- run -> starting, but Application is not available:

vertx-run-application

vertx-http-vertx-apps-no-available

-- debug -> launch, but Application is not available:

vertx-dubug-launch vertx-http-vertx-apps-no-available

artaleks9 avatar Mar 18 '24 17:03 artaleks9

Vue

  • workspace runs, but some code lines is highlight red

  • needed tools are provided

  • commands: -- install: vue-install-command

    -- build launching, but Application is not available:

vue-build-command-id vue-application-not-available

artaleks9 avatar Mar 18 '24 17:03 artaleks9

Django

Added recommended extensions and debug configuration https://github.com/devfile-samples/python-django-ex/pull/1

tolusha avatar Mar 22 '24 10:03 tolusha

Go Runtime

https://github.com/devfile/api/issues/1490

tolusha avatar Mar 22 '24 12:03 tolusha

@artaleks9 : about your comment: https://github.com/eclipse-che/che/issues/22869#issuecomment-2004470113 I have faced the same problem when check Python and Spring Boot devfiles. Solution: use https endpoints instead of http in devfile, e.g. https://github.com/devfile/registry/pull/367

dmytro-ndp avatar Apr 23 '24 12:04 dmytro-ndp

Pull request for dotnetcore31 and angular samples https://github.com/devfile/registry/pull/398 Requires merging of https://github.com/devfile-samples/devfile-stack-nodejs-angular/pull/3

vitaliy-guliy avatar May 15 '24 07:05 vitaliy-guliy

Closing as done The only missing PR is https://github.com/odo-devfiles/springboot-ex/pull/5 but it can be merged outside the scope of the issue

ibuziuk avatar Jun 18 '24 11:06 ibuziuk