che-server icon indicating copy to clipboard operation
che-server copied to clipboard

Apply GitHub server flag when resolving factory URL

Open vinokurig opened this issue 1 year ago • 3 comments

What does this PR do?

Fix an issue when starting a workspace using a public GitHub Server repo fails.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-6831

How to test this PR?

Start a workspace from a public GitHub Enterprise Server repository with a devfile. See: workspace starts

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

vinokurig avatar Jul 16 '24 08:07 vinokurig

/retest

vinokurig avatar Jul 19 '24 07:07 vinokurig

/retest

vinokurig avatar Jul 19 '24 10:07 vinokurig

/retest

vinokurig avatar Jul 22 '24 06:07 vinokurig

Verified on Eclipse Che with quay.io/eclipse/che-server:pr-701 - the functionality works properly.

artaleks9 avatar Jul 23 '24 15:07 artaleks9

/retest

vinokurig avatar Jul 24 '24 11:07 vinokurig

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, ibuziuk, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 25 '24 13:07 openshift-ci[bot]

/retest

vinokurig avatar Jul 26 '24 14:07 vinokurig

Build 3.16 :: server_3.x/350: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7330 triggered

devstudio-release avatar Jul 29 '24 08:07 devstudio-release

Build 3.16 :: update-digests_3.x/7174: UNSTABLE

No new images detected: nothing to do!

devstudio-release avatar Jul 29 '24 08:07 devstudio-release