che-dockerfiles icon indicating copy to clipboard operation
che-dockerfiles copied to clipboard
verified publisher icon eclipse-che

Adapt to newer Omnisharp-roslyn including direct support for LSP

Open mickaelistria opened this issue 8 years ago • 5 comments

See https://github.com/OmniSharp/omnisharp-roslyn/issues/968#issuecomment-356534712 OmniSharp-roslyn now directly support LSP with ./run -stdio -lsp. It's been tried successfully on Eclipse IDE with aCute. Using it allows to get rid of a bunch of dependencies such as nodejs and of some indirections.

mickaelistria avatar Jan 10 '18 08:01 mickaelistria

@tsmaeder - is this a licensing issue? I didn't think the omnisharp LSP was truly FOSS...

bmicklea avatar Feb 05 '18 12:02 bmicklea

I think it's truly OSS, at least OSS enough to be approved in an Eclipse.org project (Eclipse aCute got a CQ approved for Omnisharp-Roslyn). License is MIT, it uses mono (MIT) too and dotnet core to provide its features.

mickaelistria avatar Feb 05 '18 12:02 mickaelistria

https://dev.eclipse.org/ipzilla/show_bug.cgi?id=15334 is the Eclipse.org CQ that allowed Eclipse aCute to ship Omnisharp-Roslyn.

mickaelistria avatar Feb 05 '18 14:02 mickaelistria

@mickaelistria I will look at it. Thanks for bringing this up

ghost avatar Feb 06 '18 07:02 ghost

Tried it and failed. Somehow, Che client refuses to work: https://github.com/eclipse/che/issues/9351

ghost avatar Apr 14 '18 11:04 ghost