concierge icon indicating copy to clipboard operation
concierge copied to clipboard

Hardcoded version in framework bundle

Open svilenvul opened this issue 7 years ago • 2 comments

I am referring to:

https://github.com/eclipse/concierge/blob/9399f771aa6b327612e45ce277c793929c1bbc2b/framework/org.eclipse.concierge/src/org/eclipse/concierge/Concierge.java#L149

It is more interesting how this affects the displayed bundle version:

hardcoded-version

You can imagine how difficult was to find where this "snapshot" version came from, as it is not available in any repository... :-)

svilenvul avatar Sep 28 '18 12:09 svilenvul

If I recall correctly this thing is supposed to be set by the build tool? @JochenHiller ?

tverbele avatar Oct 01 '18 08:10 tverbele

This should be set by the build tool but I think currently it is not. For now, I will hardcode it to 5.1.0-SNAPSHOT and look into ways to have it automatically synchronized with the version info (currently in a version.txt file).

rellermeyer avatar Oct 19 '18 12:10 rellermeyer