codewind icon indicating copy to clipboard operation
codewind copied to clipboard

Turbine Functional Tests should handle projects without cw-settings

Open maysunfaisal opened this issue 6 years ago • 2 comments

Description: On Jan 20 Turbine tests, we discovered issue https://github.com/eclipse/codewind/issues/1829 where cwctl did not create .cw-settings on project create.

From a product POV, it is not necessary to have a .cw-settings file. We should still function if there is no settings file.

Our tests should reflect that as well.

There are 2 considerations for this issue:

  • [ ] Change our test case to not depend on cw-settings Note: The change may be as simple as updating the readCwSettings() function to return an empty object if the .cw-settings file does not exist
  • [ ] Validate that cwctl not creating a cw-settings file on project create doesn't cause issues on the product. This requires manual testing of each of the project types.

maysunfaisal avatar Jan 21 '20 20:01 maysunfaisal

/area iterative-dev /kind test

maysunfaisal avatar Jan 21 '20 20:01 maysunfaisal

If we let our Turbine Functional Tests still work without .cw-settings we may have two problems:

  • We are not able to catch the issue https://github.com/eclipse/codewind/issues/1829 any more, although it's from Portal, but it would be good we disable the catch after Portal's tests cover this
  • Turbine Functional Tests also test the project settings features from Turbine, so project settings will fail as well since .cw-settings is prereq for project settings tests

GeekArthur avatar Jan 31 '20 20:01 GeekArthur