Helm Secret does not delete on Che workspace delete

Open maysunfaisal opened this issue 6 years ago • 1 comments

Codewind version: OS:

Che version: IDE extension version: IDE version: Kubernetes cluster:

Description: I create a Che Codewind workspace and create a project the usual way.

Since we moved to Helm v3; there are now helm secrets generated..

The issue(not sure if its actually an issue) here is,

I had an application maysungo123 and when I edited this Go project, two secrets were created(check below)

secret/sh.helm.release.v1.cw-gosecondtest-cffc9f80-3191-11ea-91ca.v1   helm.sh/release.v1                    1      1h    modifiedAt=1578431305,name=cw-gosecondtest-cffc9f80-3191-11ea-91ca,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-jjj-ee495bc0-3193-11ea-91ca.v1            helm.sh/release.v1                    1      50m   modifiedAt=1578432225,name=cw-jjj-ee495bc0-3193-11ea-91ca,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-maysungo123-ffd0e920-3199-11ea-8597.v1    helm.sh/release.v1                    1      7m    modifiedAt=1578435197,name=cw-maysungo123-ffd0e920-3199-11ea-8597,owner=helm,status=superseded,version=1
secret/sh.helm.release.v1.cw-maysungo123-ffd0e920-3199-11ea-8597.v2    helm.sh/release.v1                    1      1m    modifiedAt=1578435197,name=cw-maysungo123-ffd0e920-3199-11ea-8597,owner=helm,status=deployed,version=2
secret/sh.helm.release.v1.cw-noooo-3d726850-3189-11ea-91ca.v1          helm.sh/release.v1                    1      2h    modifiedAt=1578427725,name=cw-noooo-3d726850-3189-11ea-91ca,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-testgo123-146b0fc0-30c6-11ea-a955.v1      helm.sh/release.v1                    1      1d    modifiedAt=1578343831,name=cw-testgo123-146b0fc0-30c6-11ea-a955,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-tuesdaygo1-fdd585c0-3182-11ea-91ca.v1     helm.sh/release.v1                    1      2h    modifiedAt=1578424965,name=cw-tuesdaygo1-fdd585c0-3182-11ea-91ca,owner=helm,status=deployed,version=1

If I remove the workspace directly without deleting the application, the secrets are left behind. I didn't delete the applications below but deleted the workspace directly:

secret/sh.helm.release.v1.cw-gosecondtest-cffc9f80-3191-11ea-91ca.v1   helm.sh/release.v1                    1      1h    modifiedAt=1578431305,name=cw-gosecondtest-cffc9f80-3191-11ea-91ca,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-jjj-ee495bc0-3193-11ea-91ca.v1            helm.sh/release.v1                    1      51m   modifiedAt=1578432225,name=cw-jjj-ee495bc0-3193-11ea-91ca,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-noooo-3d726850-3189-11ea-91ca.v1          helm.sh/release.v1                    1      2h    modifiedAt=1578427725,name=cw-noooo-3d726850-3189-11ea-91ca,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-testgo123-146b0fc0-30c6-11ea-a955.v1      helm.sh/release.v1                    1      1d    modifiedAt=1578343831,name=cw-testgo123-146b0fc0-30c6-11ea-a955,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-tuesdaygo1-fdd585c0-3182-11ea-91ca.v1     helm.sh/release.v1                    1      2h    modifiedAt=1578424965,name=cw-tuesdaygo1-fdd585c0-3182-11ea-91ca,owner=helm,status=deployed,version=1

/area iterative-dev

Jan 07 '20 22:01 maysunfaisal

We could use the label name to retrieve it:

secret/sh.helm.release.v1.cw-gosecondtest-cffc9f80-3191-11ea-91ca.v1   helm.sh/release.v1                    1      1h    modifiedAt=1578431305,name=cw-gosecondtest-cffc9f80-3191-11ea-91ca,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-jjj-ee495bc0-3193-11ea-91ca.v1            helm.sh/release.v1                    1      51m   modifiedAt=1578432225,name=cw-jjj-ee495bc0-3193-11ea-91ca,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-noooo-3d726850-3189-11ea-91ca.v1          helm.sh/release.v1                    1      2h    modifiedAt=1578427725,name=cw-noooo-3d726850-3189-11ea-91ca,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-testgo123-146b0fc0-30c6-11ea-a955.v1      helm.sh/release.v1                    1      1d    modifiedAt=1578343831,name=cw-testgo123-146b0fc0-30c6-11ea-a955,owner=helm,status=deployed,version=1
secret/sh.helm.release.v1.cw-tuesdaygo1-fdd585c0-3182-11ea-91ca.v1     helm.sh/release.v1                    1      2h    modifiedAt=1578424965,name=cw-tuesdaygo1-fdd585c0-3182-11ea-91ca,owner=helm,status=deployed,version=1

Jan 09 '20 20:01 maysunfaisal