ThomasV
ThomasV
This pull requests adds a `bip78_payjoin` field to `Invoice`. Since invoices are saved in the wallet file, a wallet_db upgrade must be added.
@rage-proof check out the code in `wallet_db.py`. An upgrade is required so that your code is compatible with wallet files created before your code is merged.
I still don't understand what is going on there. maybe we could just call clear_history in that upgrade?
@vcoolish sure, you can always restore from seed
I should have reopened this before. @SomberNight How about we catch that exception and call `wallet_db.clear_history` if it is raised?
Regarding trampoline invoices: Do you suggest to create a new tagged field for `trampoline_hints`, or are we going to reuse the existing `r` tags, and to consider them as trampoline...
The current proposal adds a single new failure message, `trampoline_fee_expiry_insufficient`. It does not specify any new failure message if a trampoline node fails to find a route to the next...
> trampoline doesn't need any new gossip mechanism and instead relies on the recipient doing a small amount of work to include trampoline hints in invoices The previous proposal had...
> Yes, I think it's better to introduce a new one, tailored for trampoline. But that is of course open to discussion if there's a better way. In practice, wallets...
> It's not like we're running out of error number, so why not add a new unknown_next_trampoline error? Like I said above, it would be useful to have distinct error...