matlab2python icon indicating copy to clipboard operation
matlab2python copied to clipboard

Add files via upload

Open brodkemd opened this issue 4 years ago • 3 comments

Here are the changes I have made. Let me know if anything needs work or if you want anything organized differently.

Things I added:

  • imports methods from local files by creating a list of all of the functions and their corresponding files

Things to ignore:

  • ignore the functions "remove_return" and "replace_keywords_in_line" these are temp fixes and are not important

Notes:

  • I have also been very busy lately so the code isn't great but I will polish it and make it better
  • I am also in the process of creating a function that will add some functionality to the array methods that are added

Thanks!

Marek

brodkemd avatar Sep 24 '21 13:09 brodkemd

I am not expecting you to merge this, I'm just looking for feedback.

brodkemd avatar Sep 24 '21 13:09 brodkemd

Hi Marek, I had a quick glanced (sorry for the delay), and look good. I have the following suggestions:

  • place your file marek_func into the folder matlab_parser and give it a name reflecting the content of this file (maybe import_handler.py).
  • add some tests in the directory test. You'll find examples in this directory. The file tests\test_files.py converts some of the files located in tests\files\. Other files in the tests folder are more "unit tests", testing smaller functions. You can add some unit tests for your import_handler for instance.

If you can take care of that, I'll be happy to merge your pull request.

Sorry again for the long delay.

ebranlard avatar Nov 19 '21 01:11 ebranlard

Hi @brodkemd Do you think you'll have time to address some of the recommendations I suggested? Thanks lot!

ebranlard avatar Nov 30 '23 16:11 ebranlard