AutoGP icon indicating copy to clipboard operation
AutoGP copied to clipboard

Remove custom tensorflow ops

Open danmackinlay opened this issue 8 years ago • 4 comments

Apparently we may be able to avoid the custom tensorflow triangular operations - https://github.com/tensorflow/tensorflow/issues/1825#issuecomment-337394937

Sorry for just jumping in here. But the tf.contrib.distributions.fill_triangular utility function might be useful. It reshapes a length-d*(d+1)/2 vector into a lower (or upper) triangular matrix (with zeros on the flip-side).

this will simplify packaging by avoiding compilation. Requires tensorflow master, however.

danmackinlay avatar Oct 18 '17 01:10 danmackinlay

Tensorflow 1.4 is out and includes triangualr matrix packing. will investigate if this remove the build step.

danmackinlay avatar Nov 02 '17 23:11 danmackinlay

Ah, tragically the operation did not make it in to tensorflow 1.4.; it will be in tenorflow 1.5 some time in the next few months.

https://www.tensorflow.org/versions/master/api_docs/python/tf/contrib/distributions/fill_triangular

danmackinlay avatar Nov 03 '17 00:11 danmackinlay

In the interim, GPFlow now has a compilation-free triangular packing called LowerTriangular which would also be an option. I do not know the performance implications fo the GPFlow approach

danmackinlay avatar Nov 03 '17 01:11 danmackinlay

(this would additionally solve #3)

danmackinlay avatar Nov 03 '17 01:11 danmackinlay