Edward Banner
Edward Banner
@PerrinJS do you have thoughts on this approach versus https://github.com/SerenityOS/serenity/pull/24917?
@nico would you be willing to take a look? I see you helped review the `cat -n` PR https://github.com/SerenityOS/serenity/pull/24382
Fixed the CI check. PR is ready for review
@PerrinJS also tagging you over here 🙂
Tagging you over here @nico as well https://github.com/SerenityOS/serenity/pull/24918#issuecomment-2296557197
This PR causes a whole bunch of tests to break. Looking at them, it's not clear to me that the tests are correct, though. Most (all?) of the tests that...
Most (all?) of the table tests are failing because `` are getting overflow when they presumably shouldn't be: https://github.com/LadybirdBrowser/ladybird/issues/1525
@kalenikaliaksandr I don't see any failures in the ref-tests. That means we don't have to address that FIXME for this issue..?
I was responding to this part of your comment: > though I bet there might be some valid regressions, particularly when CSS transform is involved. the last time I attempted...
I'm not quite sure what you mean by rebase my branch. Rebase it off of..? I don't see anything that looks off.