modelbased icon indicating copy to clipboard operation
modelbased copied to clipboard

cran update

Open DominiqueMakowski opened this issue 3 years ago • 4 comments

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_modelbased.html.

Please correct before 2022-08-20 to safely retain your package on CRAN.

The CRAN Team

DominiqueMakowski avatar Aug 06 '22 06:08 DominiqueMakowski

insight is submitted, datawizard ready for submission. I'm not sure whether modelbased needs to go before datawizard, or if that doesn't matter? (see https://github.com/easystats/easystats/issues/256) @IndrajeetPatil

strengejacke avatar Aug 06 '22 07:08 strengejacke

modelbased can be submitted.

In https://github.com/easystats/modelbased/commit/005e2ba80b967accc4a9e7587605ef48284e3a73, I had removed its reliance on datawizard::to_numeric(), so there shouldn't be any problems.

IndrajeetPatil avatar Aug 06 '22 07:08 IndrajeetPatil

I just submitted it to win-builder. @DominiqueMakowski You should receive an email soon.

Let's see if it works with the CRAN version of datawizard. I think it should.

IndrajeetPatil avatar Aug 06 '22 20:08 IndrajeetPatil

Dom, did you get any email from win-builder?

IndrajeetPatil avatar Aug 07 '22 12:08 IndrajeetPatil

I think #200 should fix some issues, also with emmeans. We should merge that PR if tests pass (some checks will fail due to emmeans requiring R >= 4.1(!))

strengejacke avatar Aug 15 '22 07:08 strengejacke

Looks like vignettes/estimate_grouplevel.rmd needs to be fixed.

strengejacke avatar Aug 15 '22 09:08 strengejacke

this notification has been generated automatically. Your package modelbased_0.8.1.4.tar.gz has been built (if working) and checked for Windows. Please check the log files and (if working) the binary package at: https://win-builder.r-project.org/114DU96fI0HB The files will be removed after roughly 72 hours. Installation time in seconds: 11 Check time in seconds: 167 Status: OK

Will look again into all of this tomorrow once I'm back in office

DominiqueMakowski avatar Aug 15 '22 14:08 DominiqueMakowski

I think all bugs are fixed now, and if win-builder passes, everything should be ok to submit (you need to set the version number to 0.8.2 or so, though). I think the other issues can wait after submission.

strengejacke avatar Aug 15 '22 14:08 strengejacke

submitted

DominiqueMakowski avatar Aug 18 '22 00:08 DominiqueMakowski

We should try to transition to {marginaleffects} as a backend in the next few releases

bwiernik avatar Aug 18 '22 02:08 bwiernik

thanks, package modelbased_0.8.5.tar.gz is on its way to CRAN.

DominiqueMakowski avatar Aug 18 '22 03:08 DominiqueMakowski

We should try to transition to {marginaleffects} as a backend in the next few releases

Agreed

DominiqueMakowski avatar Aug 18 '22 03:08 DominiqueMakowski