easyrdf icon indicating copy to clipboard operation
easyrdf copied to clipboard

dropping custom HTTP client and adopting PSR

Open madbob opened this issue 5 years ago • 1 comments

About #133

Notes:

  • breaking changes!!! Consider this for a new major release
  • the internal HTTP client has been entirely dropped in favor of external implementations, eventually configurable by the user (handling his own preferred behaviours, e.g. redirects, timeouts, authentications...). Defaults are provided out-of-the-box
  • intentionally, the first implementation of this PR do not includes rework of examples and tests (so, it will fail automated testing): waiting for feedback

madbob avatar Mar 25 '21 12:03 madbob

Awesome work @madbob! Thank you for all the time you have put into this.

It is going to take a bit for me to review this PR - it is quite a bit changeset!

I was wondering if nyholm/psr7 should be a development dependency (for running tests and examples). But I think it makes sense to get something out of the box that works, so you don't have to install/configure an HTTP client if you don't care.

njh avatar Mar 26 '21 00:03 njh