easybuild-framework icon indicating copy to clipboard operation
easybuild-framework copied to clipboard

Add patch step dict notation

Open Darkless012 opened this issue 5 years ago • 2 comments

Allow patches to be defined as dicts. This allows passing additional options for patch command.

This was needed in past because patching file with CRLF endings requires use of --binary option. (it was MOABS, but recent versions doesn't have the issue)

More about this for example here: https://stackoverflow.com/questions/2076688/how-to-use-patches-created-in-windows-with-crlf-in-linuxi https://github.com/conda/conda-build/issues/1973

The general work is done, and I don't want it to be lost. Tests are included as well, but I couldn't find a way to test some aspects.

This is why I'm writing this long description. I will add links to the changed files with commented code to bring insight.

Darkless012 avatar Aug 18 '20 08:08 Darkless012

@Darkless012 this needs a conflict resolution.

akesandgren avatar Nov 24 '20 14:11 akesandgren

@Darkless012 This needs conflict resolution and a look at flamefires suggestion.

akesandgren avatar May 24 '21 10:05 akesandgren